[PATCH] D62684: [X86] Fixup LEAs - Fix inconsistent codegen with/without debug info

Chris Dawson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 03:12:26 PDT 2019


cdawson marked an inline comment as done.
cdawson added inline comments.


================
Comment at: llvm/test/CodeGen/X86/fixup-lea-g-no-change.mir:370
+  
+  attributes #0 = { norecurse noreturn nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+  attributes #1 = { nounwind readnone speculatable }
----------------
aprantl wrote:
> Please remove all non-essential attributes. Also, if you can find any way to reduce this testcase, that would also be highly appreciated. It probably doesn't needs to be quite as long.
How would you recommend trying to reduce this test case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62684/new/

https://reviews.llvm.org/D62684





More information about the llvm-commits mailing list