[PATCH] D62884: [lld] Explicitly ignore comdat groups when parsing LTO object

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 19:17:37 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/InputFiles.cpp:623
 
-      bool IsNew =
-          ComdatGroups.try_emplace(CachedHashStringRef(Signature), this).second;
+      bool IsNew = IgnoreComdats || Symtab->ComdatGroups.try_emplace(CachedHashStringRef(Signature), this).second;
       if (IsNew) {
----------------
80 col?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62884/new/

https://reviews.llvm.org/D62884





More information about the llvm-commits mailing list