[PATCH] D62652: [llvm-objcopy][MachO] Recompute and update offset/size fields in the writer

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap accepted this revision.
alexshap added a comment.
This revision is now accepted and ready to land.

so in general this looks very promising to me, 
however test coverage needs improvements imo,  though given that at the moment we don't expose any non-trivial options here, we can add more tests incrementally. Btw - for DYSYMTAB, SYMTAB - is it possible to add YAML-based tests ? or yaml2obj's support is not sufficient for this ?

I'd also wait for @jhenderson and/or @rupprecht to take a look at this code as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62652/new/

https://reviews.llvm.org/D62652