[PATCH] D62882: Use raw strings to avoid deprecation warnings in regexp patterns

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 17:18:32 PDT 2019


jdenny accepted this revision.
jdenny added a comment.
This revision is now accepted and ready to land.

Never mind.  I see it now.  LGTM.



================
Comment at: llvm/utils/lit/lit/TestRunner.py:52
 # during expansion.
-kPdbgRegex = '%dbg\(([^)\'"]*)\)'
+kPdbgRegex = r'%dbg\(([^)\'"]*)\)'
 
----------------
The fact that `\'` will remain as `\'` bugs me because the `'` need not be escaped as part of the regex.  Hopefully that won't be deprecated one day.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62882/new/

https://reviews.llvm.org/D62882





More information about the llvm-commits mailing list