[PATCH] D62766: [Attributor] Deduce "nosync" function attribute.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:418
   default:
-    return AtomicOrdering::NotAtomic;
+    Ordering = AtomicOrdering::NotAtomic;
+
----------------
Shouldn't we here directly assume sync as it is atomic but we don't know what kind?


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:452
+    if(!ICS)
+        continue;
+
----------------
You need to check volatile and atomic for all instructions I guess and for calls nosync as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62766/new/

https://reviews.llvm.org/D62766