[PATCH] D60095: [LLD][COFF] Early load PDB type server files

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Looks like I wrote the following comment, but didn't submit it yesterday. Maybe I felt it didn't have enough information. Anyway, I see the proposed fix, I'll try it out.

In D60095#1528125 <https://reviews.llvm.org/D60095#1528125>, @rnk wrote:

> I'm seeing a lot of LNK4099 warnings after this change, and Chromium links with -Werror. I also saw a fair number while doing some local testing with asan. I'll collect some more information, but I wanted to give a heads up that this might be problematic.


This happens when linking hello world:

  $ clang-cl -c t.cpp && lld-link t.obj -debug
  lld-link: warning: Cannot use debug info for 'libcmt.lib(gs_cookie.obj)' [LNK4099]
  >>> failed to load reference 'd:\agent\_work\1\s\binaries\amd64ret\lib\amd64\libcmt.amd64.pdb': The signature does not match; the file(s) might be out of date.
  
  lld-link: warning: Cannot use debug info for 'libcmt.lib(gs_report.obj)' [LNK4099]
  >>> failed to load reference 'd:\agent\_work\1\s\binaries\amd64ret\lib\amd64\libcmt.amd64.pdb': The signature does not match; the file(s) might be out of date.
  
  lld-link: warning: Cannot use debug info for 'libcmt.lib(loadcfg.obj)' [LNK4099]
  >>> failed to load reference 'd:\agent\_work\1\s\binaries\amd64ret\lib\amd64\libcmt.amd64.pdb': The signature does not match; the file(s) might be out of date.
  ...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60095/new/

https://reviews.llvm.org/D60095