[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 11:04:16 PDT 2019


kpn updated this revision to Diff 202987.
kpn added a comment.

Address the rest of the review comments, hopefully.

I've lifted from mibintc's D62730 <https://reviews.llvm.org/D62730> the enums for the exception behavior and rounding modes. The rest of that set of changes is better left to a separate ticket after all.

Since I now have those requested enums I've changed the relevant public functions to take them instead of an MDNode*.

There is no standalone or comprehensive IRBuilder documentation that I could find. I hope the references in comments back to the LangRef are good enough. I used the exact language from it to make it easier to reference said doc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53157/new/

https://reviews.llvm.org/D53157

Files:
  include/llvm/IR/IRBuilder.h
  unittests/IR/IRBuilderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53157.202987.patch
Type: text/x-patch
Size: 14598 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190604/199d2895/attachment-0001.bin>


More information about the llvm-commits mailing list