[PATCH] D62532: [AIX] Implement function descriptor on SDAG

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/lib/CodeGen/LLVMTargetMachine.cpp:204
   if (!TargetPassConfig::willCompleteCodeGenPipeline()) {
+    if (TargetPassConfig::willInitMCObjectFile()) {
+      MCContext &Ctx = MMI->getContext();
----------------
We either need to:
1) initialize the MCObjectFileInfo to be able to use mir tests with call instructions on AIX
2) Be able to add the requisite info the the MCSymbol base class, and not need to cast callee operands to an MCSymbolXCOFF during lowering.

//If its safe// to initialize MCObjectFileInfo even when we don't have an AsmPrinter, then maybe we should just always do so for MIR output on AIX. 


================
Comment at: llvm/lib/Target/PowerPC/PPC.h:91
+    /// to "FOO at plt".  This is used for calls and jumps to external functions 
+    /// and for PIC calls on 32-bit ELF systems.
     MO_PLT = 1,
----------------
hubert.reinterpretcast wrote:
> This looks like a drive-by fix. If it is not, then clarify the relation of this comment to AIX.
This is my fault, I suggested we needed to fix comment but failed to explain it should be in a separate NFC patch. I'll land this separately for you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62532/new/

https://reviews.llvm.org/D62532