[PATCH] D62610: [DA] Add an option to control delinearization validity checks

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D62610#1529504 <https://reviews.llvm.org/D62610#1529504>, @jdoerfert wrote:

> In D62610#1527633 <https://reviews.llvm.org/D62610#1527633>, @bmahjour wrote:
>
> > In D62610#1526365 <https://reviews.llvm.org/D62610#1526365>, @jdoerfert wrote:
> >
> > > I would have liked to invert the option though. Most similar options are set up such that they allow to opt-out of the sound behavior.
> >
> >
> > Are you saying you'd like the validity checks to be off by default? Unfortunately for the cases mentioned by Dave and Michael, the compiler would have to be pessimistic and do these validity checks otherwise incorrect transformations can take place. That's why this option leaves the checks intact by default.
>
>
> I do want validity checks by default.
>
> I thought about having the option to be called something like "da-delinearization-no-checks". It would be false by default and it would avoid the "=false" part you need now. Setting it would mean you get the unsound behavior.


I agree it would be better to have an option to actively disable the checks, rather than the other way around. ( personally I also think something like `-da-disable-delinearization-checks` would be a bit more descriptive). Also, I think it is worth calling out the unsoundness of setting the option in the description.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62610/new/

https://reviews.llvm.org/D62610