[PATCH] D62809: [yaml2obj] - Change how we handle implicit sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 06:03:20 PDT 2019


grimar updated this revision to Diff 202917.
grimar marked 21 inline comments as done.
grimar added a comment.

- Addressed review comments.

Note:
Many of my answers suggest changing things in the follow-ups.
(because other independent changes need to be done to achieve the ideal behavior).
If you think it will be better I can first prepare patches for those things and rebase this one after.
I fine with either way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62809/new/

https://reviews.llvm.org/D62809

Files:
  test/tools/yaml2obj/implicit-sections.test
  tools/yaml2obj/yaml2elf.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62809.202917.patch
Type: text/x-patch
Size: 14170 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190604/9bf983c5/attachment.bin>


More information about the llvm-commits mailing list