[PATCH] D62851: [llvm-readobj] --dynamic-table: dump DT_PPC_GOT and DT_PPC_OPT

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 04:52:02 PDT 2019


jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/Inputs/elf-dynamic-tags-machine-specific.yaml:185-187
+      - Tag:   DT_PPC_GOT
+        Value: 0x200c0
+      - Tag:   DT_PPC_OPT
----------------
Should you add these two tags to the 64-bit PPC rather than create another document? It seems odd having the two different variations.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62851/new/

https://reviews.llvm.org/D62851





More information about the llvm-commits mailing list