[PATCH] D62718: [llvm-objcopy] Change output file permissions to be the same as the input file

Tue Jun 4 04:16:44 PDT 2019

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objcopy/ELF/same-permissions.test:6
+# RUN: diff %t1 %t2
+
----------------
Nit: looks like there's an additional trailing blank line here?

================
Comment at: llvm/test/tools/llvm-objcopy/ELF/strip-all-and-remove.test:2
 # RUN: yaml2obj %s > %t
-# RUN: cp %t %t1
+# RUN: cp -p %t %t1

----------------
abrachet wrote:
> jhenderson wrote:
> > abrachet wrote:
> > > I was having some permissions problems with %t1 so I am just preserving %t's permissions
> > It seems odd you're having problems in this test only. There are plenty of other tests that do this sort of copy too.
> It was certainly strange. %t had your normal 0664 permissions and %t1 got 1777. I was having a couple other problems related to lit not removing temp files. Not sure what caused this. but you're right that this is strange, I'd be happy to remove the -p.
Please do. I don't think your change should cause this behaviour difference. If it does, there's a bug either in your change or in something you've exposed with your change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62718/new/

https://reviews.llvm.org/D62718