[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 02:23:12 PDT 2019


Pierre added a comment.

In D60763#1527870 <https://reviews.llvm.org/D60763#1527870>, @thakis wrote:

> From what I can tell, the only client of OpenCLBuiltins.td is currently lib/Sema. Do you expect that to change? If not, does it make more sense to move the .td file to there?
>
> Do you expect OpenCLBuiltins.td to include other files in the future? At the moment, the `-I ${CMAKE_CURRENT_SOURCE_DIR}/../../` bit in the cmake file isn't needed for anything.


OpenCLBuiltins.td is currently only targeting lib/Sema and will be moved there.
 OpenCLBuiltins.td is not expected to include other files, this will be changed aswell.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60763/new/

https://reviews.llvm.org/D60763





More information about the llvm-commits mailing list