[PATCH] D62841: [openmp] Use libffi only when LLVM_ENABLE_FFI is on

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 23:30:29 PDT 2019


Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.

We support standalone builds of `openmp` where `LLVM_ENABLE_FFI` will not be defined. Can you add a check for `OPENMP_STANDALONE_BUILD OR` or `DEFINED LLVM_ENABLE_FFI`? Also please try to be consistent with the surrounding style, ie no whitespace after the opening and before the closing parenthesis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62841/new/

https://reviews.llvm.org/D62841





More information about the llvm-commits mailing list