[llvm] r362450 - [ORC] Use uint8_t for bitfields in SymbolTableEntry.

[Lang Hames via llvm-commits]

Author: lhames
Date: Mon Jun  3 15:02:48 2019
New Revision: 362450

URL: http://llvm.org/viewvc/llvm-project?rev=362450&view=rev
Log:
[ORC] Use uint8_t for bitfields in SymbolTableEntry.

This allows for better struct packing on MSVC, and as a bonus will eliminate a
warning on GCC builds.

Modified:
    llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h

Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h?rev=362450&r1=362449&r2=362450&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h (original)
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h Mon Jun  3 15:02:48 2019
@@ -653,16 +653,16 @@ private:
   public:
     SymbolTableEntry() = default;
     SymbolTableEntry(JITSymbolFlags Flags)
-        : Flags(Flags), State(SymbolState::NeverSearched),
+        : Flags(Flags), State(static_cast<uint8_t>(SymbolState::NeverSearched)),
           MaterializerAttached(false), PendingRemoval(false) {}
 
     JITTargetAddress getAddress() const { return Addr; }
     JITSymbolFlags getFlags() const { return Flags; }
-    SymbolState getState() const { return State; }
+    SymbolState getState() const { return static_cast<SymbolState>(State); }
 
     bool isInMaterializationPhase() const {
-      return State == SymbolState::Materializing ||
-             State == SymbolState::Resolved;
+      return getState() == SymbolState::Materializing ||
+             getState() == SymbolState::Resolved;
     }
 
     bool hasMaterializerAttached() const { return MaterializerAttached; }
@@ -670,7 +670,11 @@ private:
 
     void setAddress(JITTargetAddress Addr) { this->Addr = Addr; }
     void setFlags(JITSymbolFlags Flags) { this->Flags = Flags; }
-    void setState(SymbolState State) { this->State = State; }
+    void setState(SymbolState State) {
+      assert(static_cast<uint8_t>(State) < (1 << 6) &&
+             "State does not fit in bitfield");
+      this->State = static_cast<uint8_t>(State);
+    }
 
     void setMaterializerAttached(bool MaterializerAttached) {
       this->MaterializerAttached = MaterializerAttached;
@@ -687,9 +691,9 @@ private:
   private:
     JITTargetAddress Addr = 0;
     JITSymbolFlags Flags;
-    SymbolState State : 6;
-    bool MaterializerAttached : 1;
-    bool PendingRemoval : 1;
+    uint8_t State : 6;
+    uint8_t MaterializerAttached : 1;
+    uint8_t PendingRemoval : 1;
   };
 
   using SymbolTable = DenseMap<SymbolStringPtr, SymbolTableEntry>;