[PATCH] D62822: [LVI][CVP] Add support for urem, srem and sdiv

[Nikita Popov via Phabricator via llvm-commits]

nikic marked 2 inline comments as done.
nikic added inline comments.


================
Comment at: llvm/lib/IR/ConstantRange.cpp:792
     return multiply(Other);
   default:
+    llvm_unreachable("Unsupported binary op");
----------------
reames wrote:
> If I understand the context of the patch, xor is the only case not handled right?  If so, then I'd strongly prefer to see a case handled for xor (even if that's simply return full).  The contract of "supports all binops but xor" is not a great API for this function.  
Xor is the only unsupported integer binop. There are more unsupported float binops which aren't relevant to LVI though.

I've restored the code to returning a conservative result now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62822/new/

https://reviews.llvm.org/D62822