[PATCH] D62758: Add cdb test for inline line tables

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 11:13:56 PDT 2019


rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: debuginfo-tests/win_cdb/inline-line-gap.cpp:2
+// RUN: %clang_cl -MD -Od %s -o %t.exe -fuse-ld=lld -Z7
+// RUN: grep DE[B]UGGER: %s | sed -e 's/.*DE[B]UGGER: //' > %t.script
+// RUN: %cdb -cf %t.script %t.exe | FileCheck %s --check-prefixes=DEBUGGER,CHECK
----------------
thakis wrote:
> What are the [] needed for? Isn't DE[B]UGGER equivalent to just DEBUGGER?
It's a workaround to prevent the grep from matching the `RUN: grep` line itself. Longer term, we could lift this pattern up into a Python script that does fancier stuff, like emitting a CHECK line of `> ${cmd}`, since most debugger commands are really short (`r`) and could match anywhere unintentionally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62758/new/

https://reviews.llvm.org/D62758





More information about the llvm-commits mailing list