[PATCH] D62258: [scudo][standalone] Introduce the thread specific data structures

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 09:47:54 PDT 2019


cryptoad updated this revision to Diff 202742.
cryptoad added a comment.

This, hopefully, detangles a bit the initialization process for
the registry. In order to do that, we get rid of the mutex in favor
of our own `call_once` type construct (losely inspired by
`llvm::call_once`). We move the initialization code into
`initLinkerInitialized`.

This gets rid of the potential init loop, and hopefully makes the
code structure more coherent.

Additional, I had some local flakes while testing this, and realized
that I messed up some region log sizes in the tests. Since we are
modifyin that file here, unflake the test as well.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62258/new/

https://reviews.llvm.org/D62258

Files:
  lib/scudo/standalone/CMakeLists.txt
  lib/scudo/standalone/internal_defs.h
  lib/scudo/standalone/tests/CMakeLists.txt
  lib/scudo/standalone/tests/primary_test.cc
  lib/scudo/standalone/tests/tsd_test.cc
  lib/scudo/standalone/tsd.h
  lib/scudo/standalone/tsd_exclusive.h
  lib/scudo/standalone/tsd_shared.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62258.202742.patch
Type: text/x-patch
Size: 20504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190603/84549c6f/attachment.bin>


More information about the llvm-commits mailing list