[PATCH] D62684: [X86] Fixup LEAs - Fix inconsistent codegen with/without debug info

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 08:52:04 PDT 2019


aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1462
+  if (I != begin() && std::prev(I)->isMetaInstruction()) 
+    I = skipMetaInstructionsBackward(std::prev(I), begin());
+
----------------
I'm still somewhat confused by this line. Why are you skipping over the instruction *before* `I` here, but then check `I` (and not `std::prev(I)`) in the next line?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62684/new/

https://reviews.llvm.org/D62684





More information about the llvm-commits mailing list