[PATCH] D62609: [LLD][ELF][AArch64] Support for BTI and PAC

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: ELF/Driver.cpp:340
     error("--require-cet may not be used with -z retpolineplt");
 }
 
----------------
MaskRay wrote:
> What about adding
> 
>     if (Config->EMachine != EM_AARCH64) {
>       if (Config->PacPlt) error(...);
>       if (Config->ForceBTI) error(...);
>     }
> 
> here? Then, below, 
> 
>     if (Config->EMachine == EM_AARCH64 && Config->ForceBTI &&
> 
> The `Config->EMachine == EM_AARCH64` check can be removed.
You may ignore the comment above. The `Config->EMachine == EM_AARCH64` check below cannot be removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62609/new/

https://reviews.llvm.org/D62609