[PATCH] D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 05:20:29 PDT 2019


probinson added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h:185
+   return AFI->OffsetInBits < BFI->OffsetInBits;
+  return AFI.hasValue() < BFI.hasValue();
 }
----------------
Can you point to a test where one or both values do not have a fragment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62805/new/

https://reviews.llvm.org/D62805





More information about the llvm-commits mailing list