[PATCH] D62806: [X86] X86DAGToDAGISel::matchBitExtract(): pattern c: truncation awareness

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 04:04:35 PDT 2019


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:3050
   // Match potentially-truncated (bitwidth - y)
-  auto matchShiftAmt = [checkOneUse, Size, &NBits](SDValue ShiftAmt) {
+  auto matchShiftAmt = [checkOneUse, &NBits](SDValue ShiftAmt,
+                                             unsigned Bitwidth) {
----------------
Inconsistent - checkOneUse or &checkOneUse ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62806/new/

https://reviews.llvm.org/D62806





More information about the llvm-commits mailing list