[PATCH] D62464: [PPC32] Improve 32-bit PowerPC: many applications linked against musl may work with this patch

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 03:00:05 PDT 2019


MaskRay marked 7 inline comments as done.
MaskRay added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:2267
+          SHF_ALLOC | SHF_EXECINSTR, SHT_PROGBITS, 16,
+          Config->EMachine == EM_PPC || Config->EMachine == EM_PPC64 ? ".glink"
+                                                                     : ".plt"),
----------------
ruiu wrote:
> nit: add parentheses before ?.
I think PowerPC32 doesn't need `.glink`. I'll just delete this change.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62464/new/

https://reviews.llvm.org/D62464





More information about the llvm-commits mailing list