[PATCH] D62633: Recommit r360171: [DAGCombiner] Avoid creating large tokenfactors in visitTokenFactor.

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 2 15:26:15 PDT 2019


niravd accepted this revision.
niravd added a comment.
This revision is now accepted and ready to land.

LGTM modulo typo nit. Thanks!



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1851
+  // Re-visit inlined tokenfactors, to clean them up in case they have been
+  // removed. Skip the first tokenfacto, as this is the current node.
+  for (unsigned i = 1, e = TFs.size(); i < e ; i++)
----------------
nit: s/tokenfacto/Token Factor/g


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62633/new/

https://reviews.llvm.org/D62633





More information about the llvm-commits mailing list