[PATCH] D62793: [X86] X86DAGToDAGISel::matchBitExtract(): pattern b: truncation awareness

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 2 10:42:11 PDT 2019


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:8623
+      .zextOrTrunc(VT.getSizeInBits())
+      .isAllOnesValue();
 }
----------------
Could you not create an AllOnes equivalent MaskedValueIsZero instead? MaskedValueIsAllOnes?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62793/new/

https://reviews.llvm.org/D62793





More information about the llvm-commits mailing list