[PATCH] D62773: [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 1 12:13:58 PDT 2019


mgorny added a comment.

The more general question is: should we really reject directories here? I mean, sure, it probably makes no sense to process them but is there a technical reason to prevent user from doing it here? And if yes, then what about all the other contexts where `read()` will succeed on a directory?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62773/new/

https://reviews.llvm.org/D62773





More information about the llvm-commits mailing list