[PATCH] D62753: [llvm-lipo] Implement -archs

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/test/tools/llvm-lipo/archs-macho-binary-unknown.test:1
+# RUN: yaml2obj %s > %t
+
----------------
alexshap wrote:
> smeenai wrote:
> > alexshap wrote:
> > > compnerd wrote:
> > > > Can you avoid the temporary using:
> > > > 
> > > > `yaml2obj %s | llvm-lip - -archs | FileCheck %s`
> > > i think lipo doesn't support this (i.e. cat a.o | lipo - -archs wouldn't work), if we need this feature, we can add a proper support in llvm-lipo in the future, but i think it's a bit beyond the scope of the current patch.
> > Seems like It Just Works™. I guess the command line parsing just handles it?
> it works with llvm-lipo because in https://llvm.org/doxygen/Binary_8cpp_source.html#l00092
> MemoryBuffer::getFileOrSTDIN does the thing https://llvm.org/doxygen/MemoryBuffer_8cpp_source.html#l00143 
the only downside which i see - if smb decides to grab the shell command and replace llvm-lipo with lipo it will stop working


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62753/new/

https://reviews.llvm.org/D62753