[PATCH] D62711: [MACHO] Replaced calls to getStruct with getStructOrErr in functions returning Error or Expected or similar

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 15:13:35 PDT 2019


jakehehrlich added a comment.

In D62711#1525409 <https://reviews.llvm.org/D62711#1525409>, @Bigcheese wrote:

> It would be nice to get tests for these cases, although I realize that can be difficult as it requires malformed inputs.


This is an NFC. The error messages will change slightly but I don't think we should add the burden of adding all of those tests (which as you say are not easy) onto someone making a strict improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62711/new/

https://reviews.llvm.org/D62711





More information about the llvm-commits mailing list