[PATCH] D62651: [ARM] Add FP16 vector insert/extract patterns

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 14:01:22 PDT 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

We could possibly use a custom inserter to generate the vins sequence, but it would probably involve some benchmarking to make sure there aren't any unexpected performance penalties due to the weird register usage.  So I'm happy to put that off for now.

(On a side-note, I think you can insert a float into element zero of a vector with two vext instructions, which is the same number of instructions, but maybe lower latency.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62651/new/

https://reviews.llvm.org/D62651





More information about the llvm-commits mailing list