[PATCH] D62683: [ARM][FIX] Ran out of registers due tail recursion

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 09:49:24 PDT 2019


dmgreen added a comment.

I think this looks OK, but is would be good to get @efriedma's opinion.



================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:2329
   if (Subtarget->isThumb1Only() && Outs.size() >= 4 &&
-      !isa<GlobalAddressSDNode>(Callee.getNode()))
-      return false;
+      (!isa<GlobalAddressSDNode>(Callee.getNode()) || PreferIndirect))
+    return false;
----------------
Perhaps call this "IsIndirect" on this side of the call?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62683/new/

https://reviews.llvm.org/D62683





More information about the llvm-commits mailing list