[PATCH] D62718: [llvm-objcopy] Change output file permissions to be the same as the input file

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 31 00:41:54 PDT 2019


abrachet marked an inline comment as done.
abrachet added a comment.

I have a number of tests failing, currently 8.  I am working through them but wanted to initially get the patch looked at.



================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:209
   sys::fs::file_status Stat;
-  if (Config.PreserveDates)
-    if (auto EC = sys::fs::status(Config.InputFilename, Stat))
-      return createFileError(Config.InputFilename, EC);
+  if (auto EC = sys::fs::status(Config.InputFilename, Stat))
+    return createFileError(Config.InputFilename, EC);
----------------
I removed the check to PreserveDates because we need to stat the file either way now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62718/new/

https://reviews.llvm.org/D62718





More information about the llvm-commits mailing list