[PATCH] D62646: [WebAssembly] Fix ISel crash on sext_inreg/extract type mismatch
    Heejin Ahn via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu May 30 20:09:09 PDT 2019
    
    
  
aheejin accepted this revision.
aheejin added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1229
+        DAG.getNode(ISD::EXTRACT_VECTOR_ELT, DL, Extract.getValueType(),
+                    DAG.getBitcast(VecT, Extract.getOperand(0)), NewIndex);
+    return DAG.getNode(ISD::SIGN_EXTEND_INREG, DL, Op.getValueType(),
----------------
As we talked offline, this does not seem to do any casts, because `Extract.getOperand(0)`'s type should be `VecT` in the first place.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62646/new/
https://reviews.llvm.org/D62646
    
    
More information about the llvm-commits
mailing list