[PATCH] D62563: Fix incorrect expand of non-linear addrecs

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 15:06:14 PDT 2019


reames added a comment.

In D62563#1522063 <https://reviews.llvm.org/D62563#1522063>, @apilipenko wrote:

> ...
>  In general I like the idea of using expandAddRecExprLiterally for non-affine addrecs, I'm going to run some performance experiments with this approach to see the impact.


Artur and I spoke offline.  The workaround suggestion I made doesn't appear to really work well, but Artur is going to move forward with the expandAddRecExprLiterally idea when we'd overflow the IV type.  This seems to be a practical fix for non-affine IVs.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62563/new/

https://reviews.llvm.org/D62563





More information about the llvm-commits mailing list