[PATCH] D60696: [TableGen] New default operand "undef_tied_input".

[Sjoerd Meijer via llvm-commits]

Thanks for reporting. I will fix this my tomorrow morning. As this is not yet used, it should not lead to incorrect behaviour, if this is a bug (it is groundwork for next patches).

Thanks,
Sjoerd.
________________________________
From: Puyan Lotfi via Phabricator <reviews at reviews.llvm.org>
Sent: 30 May 2019 20:56:57
To: Simon Tatham; David Green; Sam Parker; Sjoerd Meijer; oliver.stannard at linaro.org
Cc: puyan at puyan.org; mail at justinbogner.com; lebedev.ri at gmail.com; joker.eph at gmail.com; dexonsmith at apple.com; llvm-commits at lists.llvm.org
Subject: [PATCH] D60696: [TableGen] New default operand "undef_tied_input".

plotfi added subscribers: bogner, plotfi.
plotfi added a comment.

I am seeing a build warning now. Is this a bug?

         /mnt/nvme0/llvm-project/llvm/utils/TableGen/GlobalISelEmitter.cpp: In member function ‘llvm::Error {anonymous}::GlobalISelEmitter::importDefaultOperandRenderers({anonymous}::action_iterator, {anonymous}::RuleMatcher&, {anonymous}::BuildMIAction&, llvm::DagInit*) const’:
  /mnt/nvme0/llvm-project/llvm/utils/TableGen/GlobalISelEmitter.cpp:3816:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
           if (DefaultDagOperator->getDef()->isSubClassOf("ValueType"))
           ^~
  /mnt/nvme0/llvm-project/llvm/utils/TableGen/GlobalISelEmitter.cpp:3819:11: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
             DefaultOp = DefaultDagOp->getArg(0);
             ^~~~~~~~~

@bogner


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60696/new/

https://reviews.llvm.org/D60696



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190530/e042c71f/attachment.html>