[PATCH] D61843: [DAGCombine] Match a pattern where a wide type scalar value is stored by several narrow stores

Artur Pilipenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 12:18:23 PDT 2019


apilipenko accepted this revision.
apilipenko added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:6318
+
+  DAG.ReplaceAllUsesWith(N, NewStore.getNode());
+  return NewStore;
----------------
steven.zhang wrote:
> apilipenko wrote:
> > What happens to the individual stores after? Do you rely on other DAG combine rules to remove them?
> Exactly.
Can you add a comment saying that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61843/new/

https://reviews.llvm.org/D61843





More information about the llvm-commits mailing list