[PATCH] D62430: [PPC] Correctly adjust branch probability in PPCReduceCRLogicals

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 11:34:53 PDT 2019


Carrot added a comment.

In D62430#1523424 <https://reviews.llvm.org/D62430#1523424>, @kbarton wrote:

> Hi Carrot,
>  I agree with this change, conceptually.  Have you done any performance measurements to see what the impact is?


I didn't measure its impact, and it should not have any performance impact because currently it is disabled by default.

When I worked on code layout improvements, I got an unreasonable result for test case CodeGen/PowerPC/tail-dup-layout.ll because of this bad branch probability adjustment. So I fixed it with this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62430/new/

https://reviews.llvm.org/D62430





More information about the llvm-commits mailing list