[PATCH] D62546: [FPEnv] Added a special UnrollVectorOp method to deal with the chain on StrictFP opcodes

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 08:43:10 PDT 2019


cameron.mcinally accepted this revision.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.

LGTM, with one nit inline...



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:1320
+SDValue DAGTypeLegalizer::UnrollVectorOp_StrictFP(SDNode *N, unsigned ResNE) {
+  
+  SDValue Chain = N->getOperand(0);
----------------
Not sure about LLVM's coding style, but is this extra line ok?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62546/new/

https://reviews.llvm.org/D62546





More information about the llvm-commits mailing list