[PATCH] D62602: [AArch64][SVE2] Add CPU and arch directive tests

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 07:25:51 PDT 2019


chill added inline comments.


================
Comment at: test/MC/AArch64/SVE2/directive-arch-negative.s:3
+
+.arch armv8-a+nosve2
+tbx z0.b, z1.b, z2.b
----------------
Just removing the `+nosve2` part would still make the test pass. It looks to me that `-mattr=+sve2` should be added to the command lime and the test split in five separate files, or otherwise reset arch between test cases.


================
Comment at: test/MC/AArch64/SVE2/directive-arch_extension-negative.s:3
+
+.arch_extension nosve2
+tbx z0.b, z1.b, z2.b
----------------
Likewise here, removing `.arch_extension nosve2` (resp. adding it)  has no effect on the test outcome.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62602/new/

https://reviews.llvm.org/D62602





More information about the llvm-commits mailing list