[PATCH] D62655: [llvm-readobj/llvm-readelf] - Remove gnu-relocations.test completely.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 05:54:36 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, rupprecht, MaskRay, jakehehrlich, khemant.

rL362089 <https://reviews.llvm.org/rL362089> introduced a set of yaml based reloc-types-*.test test cases
(instead of huge reloc-types.test that used a lot of precompiled binaries)
These test cases checks `LLVM-styled` dumping of the relocations.

`gnu-relocations.test` was a test case to check `GNU` styled relocations dumping.
It did that only for `elf-x86` and `elf-x86_64 targets`. It did not test all of the
relocations though.

Now, after rL362089 <https://reviews.llvm.org/rL362089>, it does not make sence to keep it.
This patch updates `reloc-types-elf-i386.test` and `reloc-types-elf-x64.test` tests
with `llvm-readelf` calls to check `GNU` styled output in one place.
It removes `gnu-relocations.test` completely.

One of intentions of doing this is also to get rid of `relocs.obj.elf-i386` and
`relocs.obj.elf-x86_64` precompiled objects completely (they are used in other tests still).


https://reviews.llvm.org/D62655

Files:
  test/tools/llvm-readobj/gnu-relocations.test
  test/tools/llvm-readobj/reloc-types-elf-i386.test
  test/tools/llvm-readobj/reloc-types-elf-x64.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62655.202165.patch
Type: text/x-patch
Size: 23772 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190530/d4d7da59/attachment.bin>


More information about the llvm-commits mailing list