[PATCH] D62609: [LLD][ELF][AArch64] Support for BTI and PAC

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/ELF/aarch64-feature-bti.s:12
+# RUN: llvm-objdump -d -mattr=+bti %tno.so | FileCheck --check-prefix=NOBTI %s
+# RUN: llvm-objdump -s %tno.so | FileCheck --check-prefix SOGOTPLT %s
+# RUN: llvm-readelf --dynamic-table %tno.so | FileCheck --check-prefix NOBTIDYN %s
----------------
Consider `llvm-readelf -x .got.plt`


================
Comment at: test/ELF/aarch64-feature-bti.s:44
+# RUN: llvm-objdump -d -mattr=+bti %t.so | FileCheck --check-prefix BTISO %s
+# RUN: llvm-objdump -s %t.so | FileCheck --check-prefix SOGOTPLT %s
+# RUN: llvm-readelf --dynamic-table %t.so | FileCheck --check-prefix BTIDYN %s
----------------
Consider `llvm-readelf -x .got.plt`


================
Comment at: test/ELF/aarch64-feature-btipac.s:104
+# EX: 0000000000210030 func2 at plt:
+# EX:   210030: 10 01 00 90                     adrp    x16, #131072
+# EX-NEXT:   210034: 11 0e 40 f9                        ldr     x17, [x16, #24]
----------------
This insn is misaligned.


================
Comment at: test/ELF/aarch64-feature-pac.s:10
+# RUN llvm-objdump -d -mattr=+v8.3a %tno.so | FileCheck --check-prefix=NOBTI %s
+# RUN llvm-objdump -s %tno.so | FileCheck --check-prefix SOGOTPLT %s
+# RUN llvm-readelf --dynamic-table %tno.so | FileCheck --check-prefix NOPACDYN %s
----------------
Consider `llvm-readelf -x .got.plt`


================
Comment at: test/ELF/aarch64-feature-pac.s:38
+# RUN: llvm-objdump -d -mattr=+v8.3a %t.so | FileCheck --check-prefix PACSO %s
+# RUN: llvm-objdump -s %t.so | FileCheck --check-prefix SOGOTPLT %s
+# RUN: llvm-readelf --dynamic-table %t.so |  FileCheck --check-prefix PACDYN %s
----------------
You may use llvm-readelf -x .got.plt to be more specific with the section you intend to dump.


================
Comment at: test/ELF/aarch64-feature-pac.s:73
+# PACDYN-NOT:      0x0000000070000001 (AARCH64_BTI_PLT)
+# PACDYN:  0x0000000070000003 (AARCH64_PAC_PLT)
+
----------------
Nit: misaligned (the nit is here just because you align such lines above..)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62609/new/

https://reviews.llvm.org/D62609