[PATCH] D62608: [ARM64, COFF] Add CodeView register mapping

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The code looks fine now.  I'm okay with putting off fixes for dumping code that incorrectly assumes x86.



================
Comment at: test/DebugInfo/COFF/register-variables-arm64.ll:87
+; Function Attrs: noinline nounwind optnone uwtable
+define internal i32 @inlineinc(i32 %a) #0 !dbg !32 {
+entry:
----------------
Do you really need two functions here, given what you're testing?

Please try to clean up the testcase IR as much as you can.  I know you probably don't want to manually edit debug metadata, since it's easy to accidentally write incorrect debug info that way, but please do what you can for the other irrelevant bits, like attributes and the llvm.ident metadata.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62608/new/

https://reviews.llvm.org/D62608