[PATCH] D62608: [ARM64, COFF] Add CodeView register mapping

Wed May 29 11:05:34 PDT 2019

efriedma added inline comments.

================
Comment at: include/llvm/DebugInfo/CodeView/CodeViewRegisters.def:354

+#ifdef CV_REGISTER_ARM64
+
----------------
It's worth taking a moment to figure out how this will generalize beyond the current patch.

Probably the right approach is to provide CV_REGISTER_ARM64, CV_REGISTER_X86, and CV_REGISTER_ALL as possibilities, where CV_REGISTER_X86 only provides the x86 entries, CV_REGISTER_ARM64 only provides the ARM64 entries, and CV_REGISTER_ALL provides the entries for all targets. That would make it clear in each place that includes CodeViewRegisters.def which registers are actually being used.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62608/new/

https://reviews.llvm.org/D62608