[PATCH] D58042: [LiveDebugValues] Emit parameter's entry value

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 05:52:59 PDT 2019


djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:169
+        if (Kind != EntryValueKind)
+          Kind = RegisterKind;
         Loc.RegNo = RegNo;
----------------
aprantl wrote:
> This looks dangerous.. are entry values somehow implicitly also register values? Iguess besed on the other patches the answer is yes, but that also means that we must `assert((!EntryValueKind || RegNo) && "entry values must be register locations")`
Yes, you are right! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58042/new/

https://reviews.llvm.org/D58042





More information about the llvm-commits mailing list