[PATCH] D61935: Fixes PPC64 Tbegin disassembling

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 19:38:46 PDT 2019


jsji added a comment.

Thanks, almost good. A few more instructions and test maybe.



================
Comment at: lib/Target/PowerPC/PPCInstrHTM.td:79
 def TRECLAIM : XForm_base_r3xo <31, 942,
                                 (outs crrc:$ret), (ins gprc:$A), "treclaim. $A",
                                 IIC_SprMTSPR, []>,
----------------
How about this?


================
Comment at: lib/Target/PowerPC/PPCInstrHTM.td:87
 def TRECHKPT : XForm_base_r3xo <31, 1006,
                                 (outs crrc:$ret), (ins), "trechkpt.", IIC_SprMTSPR, []>,
                                 isDOT {
----------------
How about this?


================
Comment at: test/MC/Disassembler/PowerPC/ppc64-encoding-p8htm.txt:6
+
+# CHECK: tabortdc. 9, r0, r0
+0x7d 0x20 0x06 0x5d
----------------
Can we also add test for others?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61935/new/

https://reviews.llvm.org/D61935





More information about the llvm-commits mailing list