[PATCH] D60242: Add IR support, ELF section and user documentation for partitioning feature.

[Eric Christopher via Phabricator via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

Some inline comment requests and if you wouldn't mind changing the type allocator separately it'd be great.

Otherwise LGTM.

Thanks!



================
Comment at: llvm/include/llvm/IR/GlobalValue.h:111
 
+  unsigned HasPartition : 1;
+
----------------
Comment please.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:963
 
+  while (Lex.getKind() == lltok::comma) {
+    Lex.Lex();
----------------
I know nothing else does, but commenting this would be great with invariants, conditions, etc.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:2986
 
+  if (Record.size() > 15)
+    NewGV->setPartition(StringRef(Strtab.data() + Record[14], Record[15]));
----------------
Comment what the conditional is checking please?


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:3078
 
+  if (Record.size() > 18)
+    Func->setPartition(StringRef(Strtab.data() + Record[17], Record[18]));
----------------
Comment what the conditional is checking please?


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:3158
 
+  if (OpNum + 1 < Record.size()) {
+    NewGA->setPartition(
----------------
Comment here too please.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60242/new/

https://reviews.llvm.org/D60242