[PATCH] D62443: [WebAssembly] Move Emscripten-specific behavior under a --emscripten flag

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 17:00:38 PDT 2019


sunfish added a comment.

In D62443#1520146 <https://reviews.llvm.org/D62443#1520146>, @sbc100 wrote:

> Wouldn't it be better to try to avoid adding a `--emscripten`?




> I think for __heap_base/__data_end we should change emscripten to export them explicitly.  (I'll look into doing that).

Sounds good.

> Once we do that then this change only removes the `-pie` `-shared` behaviour, right?

Right, those are the original motivation for the --emscripten option. I'm open to other options here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62443/new/

https://reviews.llvm.org/D62443





More information about the llvm-commits mailing list