[PATCH] D50277: [WebAssembly] Support for atomic fences

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 14:49:58 PDT 2019


sunfish added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp:111
+        report_fatal_error(
+            "ATOMIC_FENCE is not yet supported in non-emscripten OSes");
+
----------------
My understanding of https://github.com/WebAssembly/tool-conventions/issues/59 is that we can lower fence to zero instructions here, rather than aborting.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50277/new/

https://reviews.llvm.org/D50277





More information about the llvm-commits mailing list