[PATCH] D62084: Fix DWARF DebugInfo unit test errors when cross-compiling

Tue May 28 10:41:55 PDT 2019

daltenty updated this revision to Diff 201703.
daltenty added a comment.

Respond to comments round 1.

If LLVM_DEFAULT_TARGET_TRIPLE is set to empty, cmake will not define it due to the behavior of configure_file, so the fallback behavior in this patch needs to be corrected.

Rather than trying to guess a fall back for these empty triple situations (some existing tests do not handle this anyway), I've update the patch to rely on the functionality of sys::getDefaultTargetTriple().

This brings us in line with other tests and allows selection of a test triple with the LLVM_TARGET_TRIPLE_ENV functionality (introduced in D33662 <https://reviews.llvm.org/D33662>). Thus in cases where an empty  LLVM_DEFAULT_TARGET_TRIPLE is specified at configuration time, running the tests with LLVM_TARGET_TRIPLE_ENV is required.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62084/new/

https://reviews.llvm.org/D62084

Files:
  llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
  llvm/unittests/DebugInfo/DWARF/DwarfUtils.cpp
  llvm/unittests/DebugInfo/DWARF/DwarfUtils.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62084.201703.patch
Type: text/x-patch
Size: 6112 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190528/f08c8073/attachment.bin>