[PATCH] D62439: PGO] Handle cases of failing to split critical edges

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1075
+    Info.setBBInfoCount(CountValue);
+    if (Info.InEdges.size() == 1) {
+      Info.InEdges[0]->setEdgeCount(CountValue);
----------------
davidxl wrote:
> Explain this change.
nit:  edge count --> edge profile count (to be not confused with number of edges).


================
Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1081
+    }
+    // If only one out-edge, the edge count should be the same as BB count.
+    if (Info.OutEdges.size() == 1) {
----------------
edge count --> edge profile count; BB count --> BB profile count.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62439/new/

https://reviews.llvm.org/D62439