[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Fail the regression tests under Linux:

  $ ninja check-polly
  [...]
  : 'RUN: at line 1';   opt -load /home/meinersbur/build/llvm/release/lib/LLVMPolly.so -load-pass-plugin /home/meinersbur/build/llvm/release/lib/LLVMPolly.so [...]
  --
  Exit Code: 2
  
  Command Output (stderr):
  --
  opt: CommandLine Error: Option 'polly-dependences-computeout' registered more than once!
  LLVM ERROR: inconsistency in registered CommandLine options
  [...]

This error typically appears when polly is statically linked into tools (`LINK_POLLY_INTO_TOOLS=ON`), but the shared library is loaded as well at run-time (`-load /home/meinersbur/build/llvm/release/lib/LLVMPolly.so`). You probably will have to adjust `polly/test/lit.site.cfg.in`:

  if config.link_polly_into_tools == '' or \
     config.link_polly_into_tools.lower() == '0' or \
     config.link_polly_into_tools.lower() == 'n' or \
     config.link_polly_into_tools.lower() == 'no' or \
     config.link_polly_into_tools.lower() == 'off' or \
     config.link_polly_into_tools.lower() == 'false' or \
     config.link_polly_into_tools.lower() == 'notfound' or \
     config.link_polly_into_tools.lower() == 'link_polly_into_tools-notfound':

To these long turnarounds, you could test these configurations yourself. Some time ago I made an overview on which combinations of dynamic/static linking should work: https://groups.google.com/d/msg/polly-dev/vxumPMhrSEs/E50kboqlAQAJ


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61446/new/

https://reviews.llvm.org/D61446